Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support installing git-lfs in different environments and only if necessary #2611

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Improve system test dependency on git-lfs but supporting its installation in more environments (e.g. apt, dnf, yum, homebrew) and only installing if it is not already installed.

Previously running tests on MacOS natively would try to installed the debian package (which would fail).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added theme:developer-exp Theme: improve developer experience theme:testing Theme: Testing labels Jan 22, 2024
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
381 0 3 381 100 47m31.147s

…f necessary

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added this pull request to the merge queue Jan 25, 2024
Merged via the queue into thin-edge:main with commit fb82765 Jan 25, 2024
18 checks passed
@reubenmiller reubenmiller deleted the dev-git-lfs-install-improve branch July 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:developer-exp Theme: improve developer experience theme:testing Theme: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants